Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Set up editor frame expression execution integration #36187

Closed
flash1293 opened this issue May 7, 2019 · 4 comments
Closed

[Lens] Set up editor frame expression execution integration #36187

flash1293 opened this issue May 7, 2019 · 4 comments
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

  • Pulls in dependencies through old plugin and new plugin shim
  • Executes them on changes
  • Renders result into container

Reference: src/legacy/core_plugins/interpreter and implementation in POC (https://github.com/elastic/kibana/tree/feature-branch/viz-editor)

@flash1293 flash1293 changed the title Set up editor frame expression execution integration [Lens] Set up editor frame expression execution integration May 7, 2019
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@flash1293 flash1293 self-assigned this May 22, 2019
@flash1293
Copy link
Contributor Author

Just synced with @ppisljar on this:

  • This is a cross cutting concern and will be needed all over Kibana
  • Because of this we are going to move this to the data plugin and just use it in Lens
  • To get started we will implement a minimal version which will get extended with features (caching etc.) over time
  • Usage in Lens will test the feature before introducing it in the current visualize editor
interface ExecutorOptions {
    domElement?: Element;
    // TBD
}

interface ExecutorResponse {
    // TBD
}

run(expression: string | AST, options?: ExecutorOptions) => Promise<ExecutorResponse>;

CC @wylieconlon @chrisdavies

@flash1293
Copy link
Contributor Author

Synced with @timroes on this:
The run method proposed in the last comment is a convenience API on top of the stuff discussed in #25374 It can be implemented first to get Lens running, but should be marked as experimental as details around this may change.

@flash1293
Copy link
Contributor Author

Closing this as the basic functionality is there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants