Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Visualize Editor to New Platform #38269

Closed
6 tasks done
timroes opened this issue Jun 6, 2019 · 3 comments
Closed
6 tasks done

Convert Visualize Editor to New Platform #38269

timroes opened this issue Jun 6, 2019 · 3 comments
Labels
Feature:New Platform Feature:Vis Editor Visualization editor issues Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Jun 6, 2019

Conversion of the "visualize editor" (aka default editor) to new platform. The main folder folder of the editor is src/legacy/ui/public/vis/editors/default (though controls are fragmented in many other places too). The visualize editor consists of the following features/components:

  • Visualize Editor Frame (Apply/Revert, Sidebar, Tabs)
  • Data panel (Aggregation selection)
  • Individual options panel for all visualizations

The following tasks need to be done:

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:New Platform Feature:Vis Editor Visualization editor issues labels Jun 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@timroes timroes added the Meta label Jun 6, 2019
@thompsongl
Copy link
Contributor

@timroes Is there a timeline to the "Completely remove Angular" part?

EUI is looking to implement some changes to a form control (EuiSwitch), but the changes don't jibe with the Angular dirty checking mechanism used in the Vis Editor options panel (see elastic/eui#2255).

Wondering if waiting for the complete removal of Angular is the right approach, or if we should look into a shim to set $touched/$dirty.

@timroes
Copy link
Contributor Author

timroes commented Oct 24, 2019

I think you most likely don't want to wait for this. The idea is to have this removed in the next two month, but given that there is a lot of outstanding new platform migration (and we can actually run Angular in new platform), it might be that the final angular removal in the editor will fall short due to more important new platform work for now. So those 2 month are more a happy wish than an educated estimation :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:New Platform Feature:Vis Editor Visualization editor issues Meta Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants