-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Platform Config service should support deprecations #40255
Comments
Pinging @elastic/kibana-platform |
Why is handling deprecations manually a problem? It seems like a pretty trivial thing to wrap a warning log in a conditional. |
It's not only about logging a warning message. Config SchemaA user has to specify the config schema. When one property deprecated in favor of another one schema looks like:
At least we can do here is to provide a Config ValueA user has to calculate a value manually. const value = config.NewProperty || config.OldProperty |
Makes sense, thanks for the explanation. |
A migrated to New platform plugin uses NP Config service, which doesn't support Deprecations yet. It means plugins have to tweak config schema, config values and log warnings manually.
Legacy platform config uses a separate module for deprecations https://github.com/restrry/kibana/blob/0f25401fe4caaf97ff1b701d245455a0ef71ec3a/src/legacy/server/config/transform_deprecations.js#L75
The text was updated successfully, but these errors were encountered: