-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas][Data source] Use a text editor input for the ES SQL data source #40907
Comments
Pinging @elastic/kibana-canvas |
@poffdeluxe FYI, I put this in the roadmap tracker |
This SQL editor would have value for the @elastic/es-ui team because we'd be able to use it in Console to support SQL requests. |
Reopening this one as it is specifically referring to the ES SQL input, not the expression editor. |
Removing Console labels because some SQL highlighting was added in #51446 |
Closing for now as part of backlog grooming - this could be a really helpful feature, but it's pretty high-effort and doesn't fit into our current priorities for Canvas. |
Currently, the Elasticsearch SQL data source presents users with a plain textarea input to write their query. As an improvement, we could present a text editor style UI that is more familiar to developers and analysts with query writing experience.
Additionally, we could later provide syntax highlighting, validation, hints, etc., that come with the code editor. More specifically, EUI has a Code editor component that will begin using the Monaco Editor (instead of Ace) which offers such features: https://microsoft.github.io/monaco-editor/ . You can track the EUI progress here: elastic/eui#499
Long story short, once the EUI Code editor switches to using Monaco, we should use it for our ES SQL data source input.
The text was updated successfully, but these errors were encountered: