Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas][Data source] Use a text editor input for the ES SQL data source #40907

Closed
ryankeairns opened this issue Jul 11, 2019 · 6 comments
Closed
Assignees
Labels
design enhancement New value added to drive a business result Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ryankeairns
Copy link
Contributor

Currently, the Elasticsearch SQL data source presents users with a plain textarea input to write their query. As an improvement, we could present a text editor style UI that is more familiar to developers and analysts with query writing experience.

Additionally, we could later provide syntax highlighting, validation, hints, etc., that come with the code editor. More specifically, EUI has a Code editor component that will begin using the Monaco Editor (instead of Ace) which offers such features: https://microsoft.github.io/monaco-editor/ . You can track the EUI progress here: elastic/eui#499

Long story short, once the EUI Code editor switches to using Monaco, we should use it for our ES SQL data source input.

@ryankeairns ryankeairns added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Jul 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas

@shaunmcgough
Copy link

@poffdeluxe FYI, I put this in the roadmap tracker

@cjcenizal
Copy link
Contributor

This SQL editor would have value for the @elastic/es-ui team because we'd be able to use it in Console to support SQL requests.

@ryankeairns
Copy link
Contributor Author

Reopening this one as it is specifically referring to the ES SQL input, not the expression editor.

@ryankeairns ryankeairns reopened this Aug 26, 2019
@timductive timductive removed the v7.4.0 label Aug 29, 2019
@timductive timductive assigned ryankeairns and unassigned poffdeluxe Aug 29, 2019
@timductive timductive added enhancement New value added to drive a business result impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Feb 11, 2020
@yuliacech
Copy link
Contributor

Removing Console labels because some SQL highlighting was added in #51446

@yuliacech yuliacech removed Feature:Console Dev Tools Console Feature Feature:Dev Tools labels Apr 3, 2023
@Heenawter
Copy link
Contributor

Closing for now as part of backlog grooming - this could be a really helpful feature, but it's pretty high-effort and doesn't fit into our current priorities for Canvas.

@Heenawter Heenawter closed this as not planned Won't fix, can't repro, duplicate, stale Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New value added to drive a business result Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

9 participants