Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering on saved search cells broken #43453

Closed
stacey-gammon opened this issue Aug 16, 2019 · 1 comment · Fixed by #43457
Closed

Filtering on saved search cells broken #43453

stacey-gammon opened this issue Aug 16, 2019 · 1 comment · Fixed by #43457

Comments

@stacey-gammon
Copy link
Contributor

It's an obvious fix.

this:

  const actions = await api.getTriggerCompatibleActions!(triggerId, {
    embeddable: actionContext.embeddable,
  });

should be

  const actions = await api.getTriggerCompatibleActions!(triggerId, actionContext);

Most importantly though, this shows we have no test coverage for this case and should add it.

cc @streamich

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants