Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deangularize courier/search source #44659

Closed
14 tasks done
lukasolson opened this issue Sep 3, 2019 · 1 comment · Fixed by #45235
Closed
14 tasks done

Deangularize courier/search source #44659

lukasolson opened this issue Sep 3, 2019 · 1 comment · Fixed by #45235
Assignees
Labels
Feature:Search Querying infrastructure in Kibana Meta

Comments

@lukasolson
Copy link
Member

lukasolson commented Sep 3, 2019

Related: #46315, #42639

Deangularization (PR: #45235):

  • courier/fetch/request/search_request: Remove (refactor & move abort to use abort signal in searchSource.fetch, ~1 day)
  • courier/fetch/request/serialize_fetch_params: Promise, sessionId, config, esShardTimeout (~2 hours)
  • courier/fetch/call_client: Promise, es, config, sessionId, esShardTimeout, KbnUrlProvider (which relies on state) (~1 day)
  • courier/fetch/call_response_handlers: Remove (return promise to the response in searchSource.fetch) (~2 hours)
  • courier/fetch/continue_incomplete: Remove (incomplete requests aren't ever restarted) (~2 hours)v
  • courier/fetch/fetch_now: Promise (~1 hour)
  • courier/fetch/fetch_soon: Promise, config (~1 hour)
  • courier/fetch/is_request: Remove (~1 hour)
  • courier/search_poll: Remove and move events to timeFilter service (~1 day)
  • courier/search_request_queue: Remove (searchSource can handle its own queues) (~2 hours)
  • courier/search_source/_normalize_sort_request: config (~1 hour)
  • courier/search_source/search_source: Promise, config (~2 hours)
  • courier/search_strategy/default_search_strategy: Promise, config (~1 hour)
  • courier/courier: Remove (everywhere should be now using searchSource.fetch) (~1 day)
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lukasolson lukasolson changed the title Courier/search source: Move to new platform Deangularize courier/search source Sep 22, 2019
@lukasolson lukasolson added the Feature:Search Querying infrastructure in Kibana label Oct 7, 2019
@ppisljar ppisljar added the Meta label Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana Meta
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants