Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vega] Cancel discarded searches #46352

Closed
lukasolson opened this issue Sep 23, 2019 · 5 comments
Closed

[Vega] Cancel discarded searches #46352

lukasolson opened this issue Sep 23, 2019 · 5 comments
Labels
Feature:Search Querying infrastructure in Kibana Feature:Vega Vega visualizations impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@lukasolson
Copy link
Member

When a user issues a search request in a Vega visualization, we need to cancel it in the following scenarios:

  1. When the user navigates away before the search completes
  2. When a new search is requested before the prior one completes
@lukasolson lukasolson added Feature:Vega Vega visualizations Team:AppArch labels Sep 23, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lukasolson lukasolson mentioned this issue Sep 23, 2019
Closed
5 tasks
@lukasolson lukasolson added the Feature:Search Querying infrastructure in Kibana label Oct 7, 2019
@alexwizp
Copy link
Contributor

@lukasolson now Vega uses new search API #68257. I think we can close this issue.

@lukasolson
Copy link
Member Author

Are we properly sending the abortSignal to the search service, and properly aborting the abortController within Vega?

@alexwizp
Copy link
Contributor

I hope yes, we take abortSignal from theExpression Execution Context and then pass it into search service. Is it correct?
See src/plugins/vis_type_vega/public/vega_fn.ts

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@Dosant
Copy link
Contributor

Dosant commented Nov 10, 2021

I checked that vega properly cancels search requests

@Dosant Dosant closed this as completed Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Search Querying infrastructure in Kibana Feature:Vega Vega visualizations impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukasolson @Dosant @elasticmachine @alexwizp