Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KQL] [Filter editor] Cancel discarded requests for suggestions #48797

Closed
lukasolson opened this issue Oct 21, 2019 · 3 comments · Fixed by #51411 or #69769
Closed

[KQL] [Filter editor] Cancel discarded requests for suggestions #48797

lukasolson opened this issue Oct 21, 2019 · 3 comments · Fixed by #51411 or #69769
Assignees
Labels
Feature:KQL KQL Feature:Search Querying infrastructure in Kibana PR sent

Comments

@lukasolson
Copy link
Member

When a user is typing KQL, and types something along the lines of field: , we start to suggest values for that particular field. To suggest values, we make a request to Elasticsearch and do a terms query for the suggestions. For each keystroke, we make a new request, but we never end up cancelling the previous requests, which means the burden remains on Elasticsearch.

The same can be said when a user opens the filter editor and selects a field, then the is or is one of operator and begins typing in the value text input.

We need to cancel previous requests in the following scenarios:

  1. When the user navigates away before the search completes
  2. When a new search is requested before the prior one completes
@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana Feature:KQL KQL Team:AppArch labels Oct 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukasolson
Copy link
Member Author

Related: #46054

@lukasolson
Copy link
Member Author

Reopening. Requests are being cancelled in the second scenario, but not when users navigate away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:KQL KQL Feature:Search Querying infrastructure in Kibana PR sent
Projects
None yet
2 participants