Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telemetry notice per splash screen needs to be removed. #50960

Closed
bhavyarm opened this issue Nov 18, 2019 · 13 comments
Closed

Telemetry notice per splash screen needs to be removed. #50960

bhavyarm opened this issue Nov 18, 2019 · 13 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Telemetry not reproducible Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 7.5.0 BC5

Elasticsearch version: 7.5.0 BC5

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: Telemetry opt-in or opt-out is cluster wide. But right now we are displaying the telemetry notice along with splash screen per space. This needs to be removed so its status is clear.

During upgrade from 7.4.2 to 7.5.0 BC5:

  1. Create a space_b along with the default space on 7.4.2
  2. Opt out of telemetry in default space and opt in on space_b for telemetry
  3. So now users in default space think they are not opted in for telemetry and space_b users think they are opting in.
  4. (if you check advanced settings in both spaces you are opted in because telemetry is cluster wide) but default space users don't think they are opted in.
  5. Upgrade to 7.5.0 - everybody is opted in by default. But default space users get no notice that they are opted in.

On 7.5.0:

  1. Create space_b along with default space in 7.5.0
  2. Note that you are opted in by default for telemetry
  3. Disable telemetry in default space
  4. Navigate to space_b and head to advanced settings & enable telemetry
  5. Now telemetry is enabled for both spaces but users accessing default space think telemetry is disabled.

Expected behavior:
Per space splash screen shouldn't have telemetry notice + telemetry shouldn't be space configurable?

cc @alexfrancoeur @LeeDr

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Feature:Telemetry Feature:Home Kibana home application Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:Stack Services labels Nov 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@alexfrancoeur
Copy link

I wouldn't consider this a blocker for 7.5, but we'll likely want to fix in a patch release or for 7.6

@alexfrancoeur
Copy link

@joelgriffith can we tie this to the new field in the telemetry saved object for 7.5.1 or 7.6?

cc: @bmcconaghy

@epixa
Copy link
Contributor

epixa commented Dec 9, 2019

I don't think I understand this report. It sounds to me like the 7.5.0 behavior that is described here is what we intended? In other words, you see the telemetry message regardless of where you navigate to and a single advanced setting (which has text that says this is for all of kibana) toggles telemetry across the board?

@epixa epixa added Team:Pulse and removed Feature:Home Kibana home application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/pulse (Team:Pulse)

@LeeDr
Copy link

LeeDr commented Dec 10, 2019

@epixa The problem is that someone installs Kibana, sees the opt-out spash screen info but decides to stay opted-in. Then at some later point they create a new space and get the spash screen again with info to opt-out. And of course this isn't just for that space, but for the whole instance. It wasn't our desired behavior to display the opt-out message again once they've seen it once and decided not to opt-out.

I think the issue has something to do with the new space not having any index -patterns defined being a trigger to show the notice.

@TinaHeiligers
Copy link
Contributor

I can't reproduce seeing the splash screen again after creating a new space on master after creating a new space, changing opt-in options in one space and then changing to the other space. The splash screen doesn't appear again.

@alexfrancoeur
Copy link

I wonder if this was resolved when we introduced a new boolean for the notice in #50831. The steps to reproduce should be pretty simple, so if it's not reproducible I wonder if we fixed it inadvertently.

  1. Load up Kibana for the first time
  2. See welcome splash screen with notice
  3. Create space
  4. See welcome splash screen with notice

We'd expect the following:

  1. Load up Kibana for the first time
  2. See welcome splash screen with notice
  3. Create space
  4. See welcome splash screen without notice

@afharo
Copy link
Member

afharo commented Dec 17, 2019

I've also tested the scenario in the branch 7.5 and I can see the notice is gone once dismissed by any user.

In the welcome screen, the message is gone once it's dismissed.
Welcome splash

The notice is hidden for all users only when dismissed at least once.
Home page until dismissed

@Bamieh
Copy link
Member

Bamieh commented Dec 17, 2019

Thanks for investigating @afharo and @alexfrancoeur I think we can close this as resolved.

@afharo
Copy link
Member

afharo commented Dec 18, 2019

Keep in mind that after #53084 the welcome splash will always show the message, but showing enable usage data here or disable usage data here, based on the status.
The home behaviour is still the same.

@epixa epixa closed this as completed Jan 27, 2020
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Telemetry not reproducible Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

9 participants