-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry notice per splash screen needs to be removed. #50960
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
I wouldn't consider this a blocker for 7.5, but we'll likely want to fix in a patch release or for 7.6 |
@joelgriffith can we tie this to the new field in the telemetry saved object for cc: @bmcconaghy |
I don't think I understand this report. It sounds to me like the 7.5.0 behavior that is described here is what we intended? In other words, you see the telemetry message regardless of where you navigate to and a single advanced setting (which has text that says this is for all of kibana) toggles telemetry across the board? |
Pinging @elastic/pulse (Team:Pulse) |
@epixa The problem is that someone installs Kibana, sees the opt-out spash screen info but decides to stay opted-in. Then at some later point they create a new space and get the spash screen again with info to opt-out. And of course this isn't just for that space, but for the whole instance. It wasn't our desired behavior to display the opt-out message again once they've seen it once and decided not to opt-out. I think the issue has something to do with the new space not having any index -patterns defined being a trigger to show the notice. |
I can't reproduce seeing the splash screen again after creating a new space on master after creating a new space, changing opt-in options in one space and then changing to the other space. The splash screen doesn't appear again. |
I wonder if this was resolved when we introduced a new boolean for the notice in #50831. The steps to reproduce should be pretty simple, so if it's not reproducible I wonder if we fixed it inadvertently.
We'd expect the following:
|
Thanks for investigating @afharo and @alexfrancoeur I think we can close this as resolved. |
Keep in mind that after #53084 the welcome splash will always show the message, but showing enable usage data here or disable usage data here, based on the status. |
Pinging @elastic/kibana-core (Team:Core) |
Kibana version: 7.5.0 BC5
Elasticsearch version: 7.5.0 BC5
Server OS version: darwin_x86_64
Browser version: chrome latest
Browser OS version: OS X
Original install method (e.g. download page, yum, from source, etc.): from staging
Describe the bug: Telemetry opt-in or opt-out is cluster wide. But right now we are displaying the telemetry notice along with splash screen per space. This needs to be removed so its status is clear.
During upgrade from 7.4.2 to 7.5.0 BC5:
On 7.5.0:
Expected behavior:
Per space splash screen shouldn't have telemetry notice + telemetry shouldn't be space configurable?
cc @alexfrancoeur @LeeDr
The text was updated successfully, but these errors were encountered: