-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support dynamic configuration without restarts #52756
Comments
Pinging @elastic/kibana-platform (Team:Platform) |
/cc @ruflin, as we were talking about whether or not it's possible for Kibana to dynamically reload configuration values from the |
To my surprise, I learned that the existing implementation of config reloading used for logging configuration actually works for all configuration values at the Core API level today. Any config changes in the We could however improve the ergonomics of this feature by actually watching for file changes on the configuration file(s) so that it's not required for orchestrators to send the Any plugins that take advantage of this feature should ideally be testing that it works end-to-end via a functional test before documenting this as supported feature in our public documentation. If/when plugins start adopting this feature, we should also standardize on a way to indicate that a config supports hot-reloads in our documentation. I would like to note that the log messages from Core (well, actually CLI) are misleading since they only mention "logging configuration":
Since the primary ask of this issue is already supported from Core, I think we should opt to fix the log message and then close this issue. Further improvements can be considered as separate issues; and only if they come up as a request from users or our Cloud team. |
The Kibana Platform supports watching config files for changes, and then propagating those config changes to Core and Plugins via an observable. The basic plumbing is already in place.
Currently, we only formally support changing the logging configuration at runtime. This is issue is to discuss other configurations we may want to also support changing at runtime without a restart.
While some configurations will be as simple as listening to the config observable and updating accordingly, other configurations (such as enabling and disabling plugins without restarts) will require more work in Core to support.
Please add config keys that need to be able to dynamically change without restarts of the Kibana server here and the Platform team will make sure these get delegated to the proper teams:
xpack.cloud.apm.url
/xpack.cloud.apm.secret_token
: they would allow us introduce changes on Cloud and cut quite a bit the time it takes to fully initialize a deployment with APM.xpack.security.audit.*
: Allow audit logging to be configured/updated at runtime. ES already supports this, so we should too!The text was updated successfully, but these errors were encountered: