ClusterManager is created with incorrect parameters

[pgayvallet]

In the LegacyService, we are creating the cluster manager by passing the actual legacy configuration

kibana/src/core/server/legacy/legacy_service.ts

Lines 249 to 253 in 14b8727

	require('../../../cli/cluster/cluster_manager').create(
	this.coreContext.env.cliArgs,
	config,
	await basePathProxy$.toPromise()
	);

However the function actually expects the raw settings instead

kibana/src/cli/cluster/cluster_manager.js

Lines 35 to 42 in 03549fa

	export default class ClusterManager {
	static create(opts, settings = {}, basePathProxy) {
	return new ClusterManager(
	opts,
	Config.withDefaultSchema(settings),
	basePathProxy
	);
	}

From #52251 (comment):

The fix is (well, should be) easy

require('../../../cli/cluster/cluster_manager').create(
      this.coreContext.env.cliArgs,
--    config,
++    config.get(),
      await basePathProxy$.toPromise()
    );

However the legacy service tests are a mess, and are not properly mocking with correct object types (the config in test is actually a Record and not a LegacyConfig ). Already had to fix that in #52060, so would be easier to fix in a separate PR once it lands.

[elasticmachine]

Pinging @elastic/kibana-platform (Team:Platform)

[mshustov]

not sure we can get with config.get() as it expects a key. I suspect we need this https://github.com/restrry/kibana/blob/03549fae27a616961f4479020bbd55bc1e02a5d7/src/core/server/legacy/legacy_service.ts#L45 or reuse https://github.com/restrry/kibana/blob/03549fae27a616961f4479020bbd55bc1e02a5d7/src/core/server/legacy/legacy_service.ts#L44

[pgayvallet]

config is a legacy config here. config.get() returns the whole configuration when no key is provided

kibana/src/legacy/server/config/config.js

Lines 137 to 149 in bd3857a

	get(key) {
	if (!key) {
	return clone(this[vals]);
	}
	const value = _.get(this[vals], key);
	if (value === undefined) {
	if (!this.has(key)) {
	throw new Error('Unknown config key: ' + key);
	}
	}
	return clone(value);
	}

[mshustov]

So many configs 🙈