Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Allow to create custom links from the Actions drop down in APM #53187

Closed
nehaduggal opened this issue Dec 16, 2019 · 15 comments
Closed

[APM] Allow to create custom links from the Actions drop down in APM #53187

nehaduggal opened this issue Dec 16, 2019 · 15 comments
Assignees
Labels
Team:APM All issues that need APM UI Team support

Comments

@nehaduggal
Copy link

Describe the feature: Currently, the actions dropdown menu in APM is entirely curated and doesn't allow any customization. Adding this new functionality will allow a customer to add additional custom links to other dashboards/tools from APM.

Describe a specific use case for the feature: When debugging a performance issue, a customer would possibly want to navigate to custom created dashboards or tools to be able to do deeper troubleshooting. Our current menu options do not allow for adding custom links into the menu that can help a customer to navigate between custom UIs. With this option, the customer will be able to specify custom URLs in the config file which would then surface on the APM App Actions link and allow for navigation to configured links.

@nehaduggal nehaduggal added the Team:APM All issues that need APM UI Team support label Dec 16, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@nehaduggal nehaduggal changed the title APM: Allow to create custom links from the Actions drop down in APM [APM] Allow to create custom links from the Actions drop down in APM Dec 16, 2019
@katrin-freihofner katrin-freihofner self-assigned this Dec 18, 2019
@katrin-freihofner
Copy link
Contributor

I think this could work with our new actions menu:

Screenshot 2019-12-24 at 10 19 06

...dependent on #53282

@formgeist
Copy link
Contributor

@katrin-freihofner I think that's a great treatment to the custom links and the "more" option. Do you imagine that clicking "see more" transitions to a new context menu "page" like the current context menu nested functionality?

Kapture 2020-01-07 at 9 46 08

@katrin-freihofner
Copy link
Contributor

Do you imagine that clicking "see more" transitions to a new context menu "page" like the current context menu nested functionality?

Yes, exactly, I think that could work for many custom links.

@formgeist
Copy link
Contributor

Sounds good - minor nitpick; do you think we need the left icon plusInCircle for the "see more" option? There's also another icon on the right, so aligning it more with the current context menu component treatment?

@katrin-freihofner
Copy link
Contributor

No, you are right - we don't need it. I'm going to update it.

@katrin-freihofner
Copy link
Contributor

Screenshot 2020-01-07 at 10 43 23

@nehaduggal
Copy link
Author

I love the classification the Actions dropdown - it makes it super clear to the user what the different links are. The ability to "View full trace" is missing from this list- that should be in its own subsection probably at the top of the list?

@katrin-freihofner
Copy link
Contributor

The ability to "View full trace" is missing from this list- that should be in its own subsection probably at the top of the list?

This example is based on a screenshot of the actions menu of the trace sample. If we need an additional link that's fine.

@formgeist
Copy link
Contributor

@nehaduggal Currently the "View full trace" is its own option next to the Actions context in the Trace sample view. I think we'd want to keep it that way?

@nehaduggal
Copy link
Author

Ah yes, of course it is and it should remain that way. Totally my bad!

@nehaduggal
Copy link
Author

nehaduggal commented Jan 16, 2020

@katrin-freihofner @formgeist how many custom links could we actually display in the dropdown without cluttering the UI? What if a user has 15-20 different custom links- what does this dropdown look like in that scenario?

@katrin-freihofner
Copy link
Contributor

@nehaduggal it becomes a very long list, similar to this
context-menu

@formgeist
Copy link
Contributor

Since we'll most likely build a CRUD-like interface of this, perhaps we can allow for nested links within the custom links section, so users have another way of grouping say specific links together (Dashboards category, Support links etc.)

@katrin-freihofner
Copy link
Contributor

Follow-up issue elastic/apm#196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Development

No branches or pull requests

5 participants