Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove courier:batchSearches setting and usage of _msearch APIs #55140

Closed
lukasolson opened this issue Jan 16, 2020 · 2 comments · Fixed by #109350
Closed

Remove courier:batchSearches setting and usage of _msearch APIs #55140

lukasolson opened this issue Jan 16, 2020 · 2 comments · Fixed by #109350
Labels
Breaking Change Feature:Search Querying infrastructure in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@lukasolson
Copy link
Member

lukasolson commented Jan 16, 2020 •
edited
Loading

Depends on #61739.

The courier:batchSearches advanced setting is deprecated in #53766. In 8.0 (or whenever #54207 is implemented, whichever comes first), we'd like to remove this advanced setting entirely, and remove all usages of the _msearch Elasticsearch APIs in our search service.

Related: #54821, #55139
@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana Team:AppArch labels Jan 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukasolson lukasolson mentioned this issue Jan 16, 2020
Closed
@lukasolson lukasolson mentioned this issue Mar 31, 2020
Closed
@lukasolson lukasolson mentioned this issue Aug 4, 2020
Closed
@lukeelmers lukeelmers mentioned this issue Sep 15, 2020
Merged
@lukeelmers
Copy link
Member

I opened #77564 which should remove the last usage of the legacy /elasticsearch/_msearch API.

At this point the only place we are using msearch is in the legacy "Default" search strategy when batchSearches is enabled, however we are calling it via a custom /internal/_msearch route.

So to resolve what's left in this issue, I believe we need to:

  1. Remove courier:batchSearches
  2. Remove the default search strategy
  3. Remove the /internal/_msearch route

@lukasolson anything I am missing?

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Jul 29, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 13, 2021
@lukasolson lukasolson mentioned this issue Aug 19, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change Feature:Search Querying infrastructure in Kibana impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[data.search] Remove deprecated courier:batchSearches advanced setting lukasolson/kibana
3 participants
@lukasolson @lukeelmers @elasticmachine