-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index Template editor should support mappings types #55645
Comments
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Note that this change should only target 7.x, since the |
After investigation, I think the bug is more severe than I originally outlined in the issue description. We'll need to fix this with the following:
This will preserve an existing custom type and allow the user to specify a custom type, while notifying the user of the types deprecation. To help users protect themselves against this in 7.4 and 7.5 we should add a warning banner to the docs for these versions, which outlines the problem and steps to avoid it (https://www.elastic.co/guide/en/kibana/current/managing-indices.html#manage-index-templates). |
Fixed by #55804 |
@cjcenizal Do you know why Github doesn't close automatically the issue although the PR description says "Fix #xxx" ? Maybe that line should be the last of the PR description for Github to close the related issue? |
Not sure, it should still work per the docs.
I don't think the position of the line matters based on the above link. |
It is strange. I realized that since a few weeks we had to manually close the issue behind the PR... I see in the doc that it is |
In 7.5, if you create an index template that uses a type in the mappings, you'll get an error. Here's an example of mappings with a type:
Here's the resulting error:
The solution to this is to detect when types are being used and add the
include_type_name
query parameter to the underlying ES API request. For example:Response:
The text was updated successfully, but these errors were encountered: