Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork Expressions service #56747

Closed
4 tasks done
streamich opened this issue Feb 4, 2020 · 1 comment · Fixed by #57491
Closed
4 tasks done

Fork Expressions service #56747

streamich opened this issue Feb 4, 2020 · 1 comment · Fixed by #57491
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)

Comments

@streamich
Copy link
Contributor

streamich commented Feb 4, 2020

Add ability to expressions plugin to fork Expressions service, that will allow Canvas and Lens to have their private instances of Expressions service. Their private instances would have access to all global expression types and expression functions, but they could also register local expression types and expression functions that would be available only in local forks of Expression service.

Needs discussion: How conflicts are resolved, e.g if a function with the same name is registered in global and forked expression service?

  • Add fork() method to expression plugin's setup contract.
  • Forked instance of Expressions service should have access to all newly registered expression types and functions from global instance.
    • Expression renderers can be shared?
  • Forked instance should allow to register expression types and functions that are only visible in local fork.
  • Forked instance should have all the same functionality as global instance.

Parent issue: #46909

@streamich streamich added Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Feb 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich mentioned this issue Feb 4, 2020
20 tasks
@streamich streamich mentioned this issue Feb 12, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants