Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API key gets created for disabled alerts (create API) #57036

Closed
mikecote opened this issue Feb 6, 2020 · 1 comment · Fixed by #57041
Closed

API key gets created for disabled alerts (create API) #57036

mikecote opened this issue Feb 6, 2020 · 1 comment · Fixed by #57041
Assignees
@mikecote
Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0

Comments

@mikecote
Copy link
Contributor

mikecote commented Feb 6, 2020

It was caught here #56634 (comment) that API keys get created for disabled alerts when calling the create alert API with a enabled: false attribute.

The following code shouldn't execute for disabled alerts:

kibana/x-pack/legacy/plugins/alerting/server/alerts_client.ts

Line 160 in 8aa2b61

...this.apiKeyAsAlertAttributes(await this.createAPIKey(), username),

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Feb 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote mikecote mentioned this issue Feb 6, 2020
Merged
@mikecote mikecote self-assigned this Feb 6, 2020
@mikecote mikecote mentioned this issue Feb 6, 2020
Merged
@mikecote mikecote mentioned this issue Feb 7, 2020
Closed
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikecote mikecote

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't create API key for disabled alerts when calling create API mikecote/kibana
3 participants
@kobelb @mikecote @elasticmachine