Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Bytes formatting needs to be consistent across the Y-axis values #57384

Closed
cchaos opened this issue Feb 11, 2020 · 7 comments
Closed

[Lens] Bytes formatting needs to be consistent across the Y-axis values #57384

cchaos opened this issue Feb 11, 2020 · 7 comments
Labels
discuss enhancement New value added to drive a business result Feature:FieldFormatters impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@cchaos
Copy link
Contributor

cchaos commented Feb 11, 2020

Should the lower values of Bytes be decimals of the largest value? For example the Y axis in this:
image

would instead be 0.9KB, 0.5KB etc...


We might want some granularity control over what is visible as the axis labels versus what we can see in the tooltip. Ex:

Screen Shot 2020-02-10 at 14 40 16 PM

I'd like to ensure the x-axis labels are marked at the whole values, but see the decimals places in the tooltip.


Okay, both 2 and 3 are related to the same overall issue, which is that our formatters don't have any context. It's especially noticeable because the bytes formatter scales itself between orders of magnitude, but affects dates as well. For example: #7539 #51227

I don't expect to solve these issues in this PR, as it's something the bytes formatter has across Kibana. Feel free to open an issue to discuss the problem of bytes formatting on the Y axis.

Originally posted by @wylieconlon in #56253 (comment)

@cchaos cchaos added Feature:FieldFormatters Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@wylieconlon
Copy link
Contributor

This issue affects all charts in Kibana that use the bytes formatter, so I've tagged app arch on this to make sure that we are solving the right problem.

@timroes
Copy link
Contributor

timroes commented Feb 12, 2020

I am not sure if this is something that should be addressed. The purpose of the bytes field formatter is imho exactly to achieve what's described in the issue, so show values at the appropriate level, so you're getting an quicker idea on what level the bytes are without having too large numbers. If we would use the same scale for everything, we would potentially either end up with a situation where the higher levels could be 2.5GB and then you could have something like 0.00000005GB lower on the axes, or vice versa. So I don't think we should align those units across the axes.

@lukeelmers
Copy link
Member

@timroes @wylieconlon @cchaos Can this be closed or do we still want to consider it as an enhancement?

@lukeelmers lukeelmers added enhancement New value added to drive a business result discuss labels Jul 2, 2020
@wylieconlon
Copy link
Contributor

I would like to keep this open, since I see value in having a consistent scale for all the data in a visualization. The behavior being requested here would require a different type of formatter than what we have implemented in Field Formatters, because we need to consider the max and min values before calculating the display. In Tim's example where the domain is wide, we would have to apply rounding.

The main reason I tagged app arch is that these "domain-aware" formatters would most likely be a new type of field formatter. Bytes isn't the only example where we would want to do this, the other example is date formatting

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jun 16, 2021
@ppisljar
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New value added to drive a business result Feature:FieldFormatters impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants