Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Stacked to 100% option #57389

Closed
wylieconlon opened this issue Feb 11, 2020 · 4 comments
Closed

[Lens] Stacked to 100% option #57389

wylieconlon opened this issue Feb 11, 2020 · 4 comments
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

Stacking to 100% is not a single setting, but a combination of:

  • Adding a new "bar stacked as percentage" and "area stacked as percentage" chart type
  • Automatically selecting the Percent formatter
  • Supporting the Other bucket on the Terms aggregation
@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Feb 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor Author

This may be simplified if a pipeline function is added to support percentages: elastic/elasticsearch#51005

@flash1293
Copy link
Contributor

It seems like this should be a layer-level setting.

Supporting the Other bucket on the Terms aggregation

This doesn't seem like a really nice addition, but a necessity for a "percentage mode". It looks like current visualize provides percentage mode with and without an "other bucket". Can we split this out into a separate issue and prioritize independently?

This may be simplified if a pipeline function is added to support percentages: elastic/elasticsearch#51005

This would require changes in esaggs, right? Does it make sense at the current point or should we just do the data modelling in the renderer?

For both automatic adddition of the "Other" bucket as well as using a different way to fetch the data I'm not sure how to properly pass the information about a "percentage mode chart" from the visualization to the renderer. Making this a pure visualization concern we would probably simplify implementation.

@flash1293
Copy link
Contributor

When we implement this, we have to decide whether this is a layer level setting or a chart level setting.

@flash1293 flash1293 self-assigned this Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants