Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Agent configuration - package policy detail UI #57953

Closed
4 tasks
jen-huang opened this issue Feb 19, 2020 · 14 comments
Closed
4 tasks

[Fleet] Agent configuration - package policy detail UI #57953

jen-huang opened this issue Feb 19, 2020 · 14 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jen-huang
Copy link
Contributor

jen-huang commented Feb 19, 2020

image
image

image

View in Figma

Video walkthrough: https://share.getcloudapp.com/8LuJAq5Z

Add agent configuration data source details UI in the form of a flyout that appears when user clicks into a data source in the table or choses "view data datasource" from the action menu. The flyout has a human-readable view and a raw YAML view.

Small note: Not shown in the screenshot, but some inputs can have top-level settings, meaning they aren't specified at the stream level. In these cases, we should show the input top level settings above the "Streams: X / Y" row, using the same style as the key/value pairs in the "Definition" section above.

Tasks

  • Add flyout
  • Add Overview tab
  • Add YAML tab
  • Allow flyout to be deep-linked
@jen-huang jen-huang added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Feb 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest (Feature:EPM)

@paul-tavares
Copy link
Contributor

@jen-huang picking this up - hope its ok 😃

@jen-huang
Copy link
Contributor Author

@paul-tavares I think the designs for this flyout has changed, it might be better to pick up #57952 first?

@paul-tavares
Copy link
Contributor

Sounds good. Will put this on hold and focus on the one you referenced. Thanks.

@paul-tavares paul-tavares removed their assignment Mar 12, 2020
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@ruflin
Copy link
Contributor

ruflin commented Mar 30, 2020

@hbharding Could you update this issue based on the most recent discussion on how this should look or open a new issue?

@hbharding
Copy link
Contributor

@paul-tavares @jen-huang @ruflin Apologies for the delay. I updated this issue with new screenshots and a link to a video walk through. Let me know if you have any questions.

@ruflin
Copy link
Contributor

ruflin commented Apr 23, 2020

@hbharding Could you double check this issue if it really is what we want to deliver in alpha1?

@jen-huang jen-huang added Ingest Management:beta1 and removed Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Apr 28, 2020
@jen-huang
Copy link
Contributor Author

jen-huang commented Apr 28, 2020

@ruflin @hbharding I'd like to kick this issue to Beta, what do you think? For alpha, we already have implemented the full agent config YAML tab (not in flyout, sibling of Data sources and Settings tabs). That YAML tab & edit data source are two ways the user can view data source details for alpha.

@ruflin
Copy link
Contributor

ruflin commented Apr 29, 2020

@jen-huang SGTM

@hbharding
Copy link
Contributor

Hey sorry for the late reply. Yes, since we already built the functionality before I updated the design, lets move this to beta for an improvement.

@ph
Copy link
Contributor

ph commented Oct 16, 2020

@hbharding @jen-huang @mostlyjason How much of this is still valid?

@jen-huang
Copy link
Contributor Author

@ph I think this entire issue is still valid. We don't have any integration policy detail UI atm.

@mostlyjason
Copy link
Contributor

Why is a flyout better than just taking the user to the edit page? The edit page serves as both a viewer and an editor. I could see this being useful if a user wants to quickly inspect multiple integration policies. Is there another use case I'm missing?

@jen-huang jen-huang changed the title [Ingest] Agent configuration - data source detail UI [Fleet] Agent configuration - package policy detail UI Nov 23, 2020
@jen-huang
Copy link
Contributor Author

Closing as the use case still hasn't really come up, a year later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

7 participants