Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest] Agent configuration - edit data source UI #57957

Closed
jen-huang opened this issue Feb 19, 2020 · 5 comments · Fixed by #64727
Closed

[Ingest] Agent configuration - edit data source UI #57957

jen-huang opened this issue Feb 19, 2020 · 5 comments · Fixed by #64727
Assignees
Labels
design Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Ingest Management:alpha1 Group issues for ingest management alpha1 Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jen-huang
Copy link
Contributor

jen-huang commented Feb 19, 2020

image
image

View in Figma
Figma prototype

Video walkthrough: https://share.getcloudapp.com/lluyKkp2

  • note: small change since recording. The EuiBottomBar should always be visible, but the submit button should be disabled unless the form state becomes dirty. We indicate in the bottom left "you have unsaved changes"

You can edit a data source by clicking on its name in the table, or by clicking the actions icon and choosing "edit data source". Upon saving the data source, return to the agent config page and show a success toast that says:
title: (checkmark icon) Successfully updated "name of data source"
message: (conditional) Fleet will deploy updates to all agents that use the "name of config" configuration

@jen-huang jen-huang added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Feb 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest (Feature:EPM)

@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@ruflin
Copy link
Member

ruflin commented Mar 30, 2020

@jen-huang @hbharding We decided not to go with this approach. Should we close this issue or update it?

@hbharding
Copy link
Contributor

@ruflin @jen-huang I updated screenshot and provided a video explanation

@ruflin
Copy link
Member

ruflin commented Apr 2, 2020

@hbharding Could you update it again with the most recent discussion we had? I think we don't need the View Data source at the moment and the "modified streams" should go away.

@ph ph added the Ingest Management:alpha1 Group issues for ingest management alpha1 label Apr 2, 2020
@jen-huang jen-huang self-assigned this Apr 23, 2020
@kevinlog
Copy link
Contributor

FYI @paul-tavares we'll eventually need to tie "edit datasource" to Endpoint as well. I created this for us to execute - https://github.com/elastic/endpoint-app-team/issues/382

We can discuss the best way for that experience to work

FYI @caitlinbetz @bfishel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Ingest Management:alpha1 Group issues for ingest management alpha1 Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants