Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Add dynamic day and night overlay #60231

Closed
Tracked by #154870
pingoolefoo opened this issue Mar 16, 2020 · 13 comments
Closed
Tracked by #154870

[Maps] Add dynamic day and night overlay #60231

pingoolefoo opened this issue Mar 16, 2020 · 13 comments
Labels
enhancement New value added to drive a business result Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@pingoolefoo
Copy link

Describe the feature:
When creating a real-time map of the activity of a company, it might be useful to display the day / night cycle so that anyone can easily correlate the activity with the daylight cycle.

Ideally, we could have a shaded overlay with civil twilight, nautical twilight, astronomical twilight and night.

Describe a specific use case for the feature:
This kind of map can be very useful when dealing with planes & transportation scheduling,
preview

Side note:
I've also found this project: rossengeorgiev/nite-overlay

@nreese nreese added enhancement New value added to drive a business result [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Mar 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor

@pingoolefoo thanks for the feature request. I assume it would be dynamically linked to the time-picker?

Do you have an idea on how this layer should behave when a time-range is selected that stretches multiple days/hours?

@pingoolefoo
Copy link
Author

@thomasneirynck I was initially thinking of this as a somewhat "real-time" map, but your point is completely valid.

To me, it can be linked with the time-picker if and only if data fits in narrow time buckets. To display larger timescales, one might have to use some sort of animation to show the evolution of the dataset.

@jsanz
Copy link
Member

jsanz commented Mar 18, 2020

This layer (maybe we could consider it a basemap extension?) would only make sense if there's something like a time slider that represents a moment in time inside the wider range expressed in the general Kibana time picker.

The discussion around a time slider is captured at #27714 so unless a better UI can be defined I'd say a feature like this is blocked.

@pingoolefoo
Copy link
Author

A feature like this can effectively be considered at first as a basemap extension to represent a moment in time. I do believe that the time slider can be added at a later time, as the elasticians & the greater elastic community come with a better ui.

@nreese
Copy link
Contributor

nreese commented Mar 18, 2020

A feature like this can effectively be considered at first as a basemap extension to represent a moment in time. I do believe that the time slider can be added at a later time, as the elasticians & the greater elastic community come with a better ui.

+1. I would not block a day/night layer by a time slider. Kibana already has a time picker that could be used to adjust the time.

I think it would make sense to have an EMS service that accepts a time range and returns day/night cycle raster tiles for that range. If the range is over 24 hours then the service could just return 400 code. On the Kibana side, the layer could disable itself when the selected time range is greater than 24 hours just like layers show/hide based on zoom level.

@jsanz
Copy link
Member

jsanz commented Mar 18, 2020

Maybe we could compute the overlay for the max/min boundaries of the time picker, when they don't span for more than 24 hours, and then use the midpoint of the range if it's smaller than something like an hour?

@pingoolefoo
Copy link
Author

pingoolefoo commented Mar 18, 2020

Maybe we could compute the overlay for the max/min boundaries of the time picker, when they don't span for more than 24 hours, and then use the midpoint of the range if it's smaller than something like an hour?

Good idea. Doing so will introduce some approximations but will be good enough for most scenarios.

@nickpeihl
Copy link
Member

Would we need to invert the layer when displayed over the Dark road map? 😅

Maybe we could compute the overlay for the max/min boundaries of the time picker, when they don't span for more than 24 hours, and then use the midpoint of the range if it's smaller than something like an hour?

The point-in-time we use for the overlay must be blatantly obvious to the user in the UI (and maybe separately configurable), especially when looking at a large time range in Kibana.

I think it would make sense to have an EMS service that accepts a time range and returns day/night cycle raster tiles for that range. If the range is over 24 hours then the service could just return 400 code. On the Kibana side, the layer could disable itself when the selected time range is greater than 24 hours just like layers show/hide based on zoom level.

I think it could also be accomplished on the client. The code to create a GeoJSON polygon is not computationally heavy. Then it's just a matter adding a new overlay layer containing the calculated GeoJSON polygon on the map. Leaflet.Terminator is another example we could draw from.

@nreese
Copy link
Contributor

nreese commented Mar 18, 2020

I think it could also be accomplished on the client. The code to create a GeoJSON polygon is not computationally heavy.

+1, Keeping everything local would be great.

@Schiffsradar
Copy link

Here is a Website that uses a Leaflet Map with Day and Night Layer. Link to Website
There you can see the shaded overlay with civil twilight, nautical twilight, astronomical twilight and night.

@jb1b84 jb1b84 added Feature:Maps Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@jb1b84 jb1b84 removed the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Nov 3, 2022
@nreese nreese added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Mar 9, 2023
@nreese
Copy link
Contributor

nreese commented Apr 12, 2023

In order to provide better transparency of priorities, issues that will not be prioritized within the next 24 months are being closed.

Tracking request in Maps ice box #154870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Maps impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

8 participants