Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] UI update agent enrollment instructions #61076

Closed
nchaulet opened this issue Mar 24, 2020 · 9 comments
Closed

[Fleet] UI update agent enrollment instructions #61076

nchaulet opened this issue Mar 24, 2020 · 9 comments
Assignees
Labels
design Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Ingest Management:alpha1 Group issues for ingest management alpha1 Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@nchaulet
Copy link
Member

nchaulet commented Mar 24, 2020

image
image

Link to Figma
Link to prototype
Video walkthrough

The "Enroll new agent" flyout can be triggered from three places:

image
image
image

Small note:

  • the row of data sources should wrap to a new line if they don't fit on a single line.
@nchaulet nchaulet added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Mar 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@ph ph added the Ingest Management:alpha1 Group issues for ingest management alpha1 label Apr 2, 2020
@hbharding
Copy link
Contributor

I updated the issue with screenshots and video explanation. Let me know if you have run into any questions!

@ruflin
Copy link
Member

ruflin commented Apr 9, 2020

I like the list of datasource with icons, great idea. For alpha 1 lets skip anything around test connection.

@hbharding
Copy link
Contributor

hbharding commented Apr 15, 2020

We already have a "check for agents" feature working in the code base. This design mimics that functionality, except the "checking for new agents..." aspect in my design is slightly different. Currently, there is a grey box that says "checking for new agents" with a loading spinner that appears automatically whenever the flyout is opened. In my design, the user has to click the button for the polling to appear (Behind the scenes, we are always polling, and we use a "flyout opened" timestamp to figure out if it's a "new" agent). I think this experience is slightly less surprising and more intuitive. By giving the user a button to click, it feels like they're completing a step (albeit, an optional one). This also puts the user in control, and they get immediate satisfaction when they see that agents were found. Currently, users might miss the confirmation message because they're focused on another window, typing agent enroll and agent run in their terminal.

@ruflin do you want to:

  1. Remove the current "checking for new agents" experience
  2. Update the current experience to match these designs
  3. Keep the current experience in the codebase as is

I suspect number 3. :)

@ruflin
Copy link
Member

ruflin commented Apr 17, 2020

Are we actually checking for new agents or just checking for agents? (@nchaulet ). I think we need to have a deeper technical discussion on what we can actually detect and what not. The current probably works well for getting started before you have an agent but gets blurry afterwards. To not be required to have this discussion right now, my preference is 1 on the UI level.

@nchaulet
Copy link
Member Author

@ruflin we are currently checkin for agent that have been created after you open the UI

@ruflin
Copy link
Member

ruflin commented Apr 20, 2020

@nchaulet Ok. In this case I'm fine sticking to 3.

@nchaulet
Copy link
Member Author

the list of datasource with icons already exists (I created it for config reassignment we can probably reuse it)

@nchaulet
Copy link
Member Author

nchaulet commented May 4, 2020

@ph the related issue where I need the download URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Ingest Management:alpha1 Group issues for ingest management alpha1 Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

6 participants