-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EPM] Change EPM package api route from POST to PUT #62479
Comments
Pinging @elastic/ingest-management (Feature:EPM) |
I believe the consensus was to use I think |
Okay, not sure why we came to that consensus. Because this action is idempotent I think PUT is more intuitive. |
It was during a weekly sync. Good Enough™️ is my TL;DR; There can be issues with PUT and DELETE. I think our specific example was @jen-huang using POST over DELETE due to an issue passing ids(?) |
Yes the jen example was using POST for bulk delete operation I think it's still ok to use DELETE for operation that concern one resource only. |
Closing for now. |
PUTing a package will install a package if it does not exist or perform an update if it does. Updating a package to a new version is similar to just installing a package.
The route to change:
/api/ingest_manager/epm/packages/nginx-1.2.0
@jfsiii Let me know if you see any issues with this proposed change
The text was updated successfully, but these errors were encountered: