Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] Inventory's custom group-by dialog acts weirdly #62798

Closed
sorantis opened this issue Apr 7, 2020 · 9 comments
Closed

[Metrics UI] Inventory's custom group-by dialog acts weirdly #62798

sorantis opened this issue Apr 7, 2020 · 9 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@sorantis
Copy link

sorantis commented Apr 7, 2020

Browser: Chrome
Kibana - latest

When opening a custom group by dropdown the the dialog is acting weirdly:
group-by bug

cc: @simianhacker

@sorantis sorantis added bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Apr 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker
Copy link
Member

@sorantis What's the weird part? The fact that is changes size OR the little flash of the "drop" down right before it moves into the correct position?

@sorantis
Copy link
Author

@simianhacker yes, the little flash.

@simianhacker
Copy link
Member

@elastic/eui-design Thoughts?

@cchaos
Copy link
Contributor

cchaos commented Apr 17, 2020

It's a known issue when the EuiComboBox is the first focusable element in a EuiContextMenu panel with ownFocus: elastic/eui#1454

@jasonrhodes
Copy link
Member

Here's a possible workaround we should look into: elastic/eui#1454 (comment)

@simianhacker
Copy link
Member

@jasonrhodes @cchaos That workaround won't work because when initialFocus is triggered the element we would try to focus on doesn't exist yet. This still appears to be broken in master. Has #56222 been merged into master?

@jasonrhodes
Copy link
Member

It looks like #56222 is a different type of workaround:

Debugging this with @thompsongl, we figured this is due to EuiComboBox being rendered inside EuiPopover. The first element inside EuiPopover gets focus, which is in this case EuiComboBox, and the content of the combo box is rendered before popover has finished rendering. The workaround here is to pass an element for EuiPopover to put focus on, and if the element has no width and height, it will look seamless.

I'm not sure I 100% understand the solution but does this sound like something we could try in this case, @simianhacker ?

@simianhacker simianhacker removed their assignment May 24, 2021
@smith
Copy link
Contributor

smith commented Feb 27, 2023

Not sure if this is still valid. Please reopen if it's still an issue.

@smith smith closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2023
@zube zube bot closed this as completed Feb 27, 2023
@zube zube bot added [zube]: Done and removed [zube]: Ready labels Feb 27, 2023
@zube zube bot removed the [zube]: Done label May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

7 participants