Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Courier should fail early if it receives a response it can't process #6399

Closed
epixa opened this issue Mar 3, 2016 · 2 comments
Closed

Courier should fail early if it receives a response it can't process #6399

epixa opened this issue Mar 3, 2016 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana

Comments

@epixa
Copy link
Contributor

epixa commented Mar 3, 2016

Courier deals in json responses, but if it doesn't receive a json response, it doesn't fail right away. Instead, responses start going through the chain of response handlers and such, and eventually a non-json response will cause a JS error when you attempt to access the property timed_out on a non-object.

We do need to make sure we're not sending courier bogus responses, but courier can probably fail earlier with a more useful error message when it does happen.

@epixa epixa added the P3 label Mar 3, 2016
@spalger spalger added the bug Fixes for quality problems that affect the customer experience label Mar 3, 2016
@epixa epixa removed the P3 label Apr 25, 2017
@cjcenizal cjcenizal added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jul 16, 2018
@lukasolson lukasolson added the Feature:Search Querying infrastructure in Kibana label Mar 26, 2019
@epixa epixa added Team:AppArch and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jul 24, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lukasolson
Copy link
Member

This has been resolved through the many refactorings that have happened recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana
Projects
None yet
Development

No branches or pull requests

5 participants