Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Deangularize loading spinner #65449

Closed
kertal opened this issue May 6, 2020 · 1 comment · Fixed by #67165
Closed

[Discover] Deangularize loading spinner #65449

kertal opened this issue May 6, 2020 · 1 comment · Fixed by #67165
Assignees
@stratoula
Labels
Feature:Discover Discover Application good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented May 6, 2020

The part of Discover displaying the loading state is still Angular. This should be converted to React using the Eui Loading Spinner.

Bildschirmfoto 2020-05-06 um 12 29 41

This is the part of the Angular template that has to be replaced with a new directive

kibana/src/plugins/discover/public/application/angular/discover.html

Line 62 in 8a65950

<div ng-hide="fetchError" class="dscOverlay">

Here's high level description how to create and register an angular directive in Discover #65326
@kertal kertal added good first issue low hanging fruit Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula mentioned this issue May 21, 2020
Merged
3 tasks
@stratoula stratoula self-assigned this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
Feature:Discover Discover Application good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Deangularize the loading spinner stratoula/kibana
3 participants
@kertal @elasticmachine @stratoula