Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Use ML plugin APIs for querying and capabilities in Service Maps #66370

Closed
ogupte opened this issue May 13, 2020 · 7 comments
Closed

[APM] Use ML plugin APIs for querying and capabilities in Service Maps #66370

ogupte opened this issue May 13, 2020 · 7 comments
Assignees
Labels
Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture

Comments

@ogupte
Copy link
Contributor

ogupte commented May 13, 2020

For Service map integration with machine learning, APM should list ml in optionalPlugins in kibana.json in order to leverage the mlClient and mlCapabilities APIs exposed by ML's plugin setup contract. Similar to how SEIM handles ml integration (https://github.com/elastic/kibana/blob/master/x-pack/plugins/siem/server/lib/machine_learning/authz.ts#L117-L118). In other areas of integration with ML, this would allow more appropriate messaging in the ml integration flyout, and transaction charts.

@sorenlouv sorenlouv added technical debt Improvement of the software architecture and operational architecture Team:APM All issues that need APM UI Team support labels May 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@jgowdyelastic
Copy link
Member

I addition to using mlCapabilities from ML's shared services, all plugins which perform searches on ML's results index will need to switch using our shared mlSearch function which includes license and user capabilities checks. This change is needed for ML's adoption of spaces, where all access to ml indices will need to be secured behind a kibana api.
mlSearch is a basic wrapper around callAsCurrentUser('search'.... which hardcodes the ml results index, so can be called in the way.

@ogupte
Copy link
Contributor Author

ogupte commented Jun 10, 2020

This was accomplished in #68485

@jgowdyelastic
Copy link
Member

jgowdyelastic commented Jun 11, 2020

This may have been closed prematurely as there are still some APM functions which search the ML results index directly.
On master I can still see functions making use of getMlIndex and searching directly.
getMlBucketSize
getAnomaliesData
anomalySeriesFetcher

Unless this work is to be covered by a different issue? The title suggests that it will cover all queries for ML data.

@sorenlouv
Copy link
Member

@ogupte Will you create a new issue to track the remaining work?

@ogupte
Copy link
Contributor Author

ogupte commented Jun 12, 2020

I'll change the name and description on this issue, and move remaining work to the new issue

@ogupte ogupte changed the title [APM] Use ML plugin APIs for querying and capabilities [APM] Use ML plugin APIs for querying and capabilities in Service Maps Jun 12, 2020
@ogupte
Copy link
Contributor Author

ogupte commented Jun 12, 2020

#69092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

4 participants