Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Creating test packages and where to store them #67372

Closed
neptunian opened this issue May 26, 2020 · 6 comments
Closed

[Ingest Manager] Creating test packages and where to store them #67372

neptunian opened this issue May 26, 2020 · 6 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@neptunian
Copy link
Contributor

Once we have the ability to run the registry locally, we need packages that are defined for the purpose of testing all the various cases which don't always exist in "real" packages.

  • Where should we store these packages? In Kibana or in the registry?
  • How should we go about creating them? Perhaps a modified System package? Ideally we can also use these for functional or e2e tests, for example updating a package while the agent is running and sending data
@neptunian neptunian added Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels May 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ruflin
Copy link
Contributor

ruflin commented May 27, 2020

We should store these packages in Kibana. This should make the tests reproducible. Each Kibana commit will be attached to a specific set of packages and a specific commit of the registry.

The system package is rather complex. I would create packages as minimal as possible that cover our test case. This will make it easier to maintain.

@neptunian It would be great to have a list of all the test cases you want to cover so we can start crafting the packages accordingly.

@neptunian
Copy link
Contributor Author

These are some of the tests I think are relevant to crafting the packages.

  • testing the package installs all assets correctly, every type of asset to install should exist
  • in an update, the old assets that don’t exist in the upgrade version were deleted (eg: the upgrade package has removed a visualization)
  • in an update, templates have field mappings with different data types (current index must be rolled over).
  • Fails when trying to install/update to an outdated version

@neptunian
Copy link
Contributor Author

@ruflin if the packages live in Kibana, that means we can point the locally running registry to serve those packages?

@ruflin
Copy link
Contributor

ruflin commented Jun 8, 2020

By local I assume you mean the one running as part of the KB tests? Then yes.

@skh
Copy link
Contributor

skh commented Aug 10, 2020

Closing this as we now have test packages in the api integration test fixtures. Please reopen if more needs to be done that I'm not aware of.

@skh skh closed this as completed Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

4 participants