Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Migrate to the new space-aware ML APIs #67936

Closed
weltenwort opened this issue Jun 2, 2020 · 4 comments
Closed

[Logs UI] Migrate to the new space-aware ML APIs #67936

weltenwort opened this issue Jun 2, 2020 · 4 comments
Labels
blocked Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Jun 2, 2020

Summary

When the ML plugin migrates to new, space-aware Kibana APIs (#64172), the parts of the Logs UI that integrate with ML will have to adapt.

The readiness of this effort is contingent on the availability of the new APIs:

@weltenwort weltenwort added blocked Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 2, 2020
@weltenwort weltenwort added this to the Logs UI 7.9 milestone Jun 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@sgrodzicki sgrodzicki removed this from the Logs UI 7.9 milestone Jun 26, 2020
@jasonrhodes
Copy link
Member

@weltenwort can we list out what still needs to be done to make this adaptation process complete? My understanding is we don't need to do anything, but that we can back out our own Space management (via Job ID) as long as we figure out how to be backwards-compatible. Is that the gist of it or is there more to it than that?

@weltenwort
Copy link
Member Author

It depends a bit on how the Kibana-side ML APIs will change as part of this.

But from what I currently know about that, I agree that most of the changes will be related to the space id encoded in the job name. Ideally there will be an automatic migration by the ML plugin, which parses the space id out of the job id and assigns it to the correct space. That would remove the need for maintaining additional backwards-compatible code paths. We'd only have to adjust how the getJobId function derives the expected job ids on our side (i.e. remove the spaceId parameter).

@weltenwort
Copy link
Member Author

Done by way of #68905, #77916 and #83127.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

4 participants