Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Rename and re-enable EPM api integration tests #67943

Closed
skh opened this issue Jun 2, 2020 · 6 comments
Closed

[Ingest Manager] Rename and re-enable EPM api integration tests #67943

skh opened this issue Jun 2, 2020 · 6 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@skh
Copy link
Contributor

skh commented Jun 2, 2020

For unknown reasons[*], the tests in x-pack/test/epm_api_integration/ are currently not run. Of of the tests is failing due to the changes to index templates v2.

This task is to

  • rename the directory to ingest_management_api_integration
  • fix the failing test
  • enable the tests in CI by adding them to x-pack/scripts/functional_tests.js

[*] This must have happened before the merge to master, so the corresponding commit(s) have been lost to commit squashing, so we don't know what the reason for disabling them was.

@skh skh added technical debt Improvement of the software architecture and operational architecture Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels Jun 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nchaulet
Copy link
Member

nchaulet commented Jun 2, 2020

@skh we also have ingest_manager test x-pack/test/api_integration/apis/ingest_manager/ and /x-pack/test/api_integration/apis/fleet/
We probably want to move everything in one place

@ph ph added bug Fixes for quality problems that affect the customer experience and removed technical debt Improvement of the software architecture and operational architecture labels Jun 2, 2020
@ph
Copy link
Contributor

ph commented Jun 2, 2020

We should consider this more like a bug than technical deb, I've increased priority on it.

@skh
Copy link
Contributor Author

skh commented Jun 2, 2020

@nchaulet Yes. The reason epm_api_integration is a separate directory is that it has a different config.ts from the ones in api_integration, because it sets a different registry url in the settings.

With #61699 this will all need to be consolidated, but I think we should get the tests running again first, regardless of when we'll have docker in CI.

@paul-tavares
Copy link
Contributor

Would this separate config.ts still run everything that is in x-pack/test/functional/?

When we (endpoint) were setting up these types of tests that interacted with Ingest APIs we also found that we needed to remove ourselves from the main set of functional test. If I remember correctly, when @jonathan-buttner tried it he got failures in other plugin tests which would have need to be address (maybe a heavy lift?). I'm thinking there may be value in ensuring that Ingest (and SIEM-Endpoint) are run along with other plugins so that we assure runtime compatibility.

(FYI: Endpoint integration tests (x-pack/test/functional_endpoint) are also currently turned off due to the move of code to SIEM. We will be re-focusing on those soon to re-enable them)

/cc: @kevinlog , @nnamdifrankie

@skh
Copy link
Contributor Author

skh commented Jun 2, 2020

@paul-tavares Good points, thanks. I frankly don't know yet. I would prefer if our tests need as little special configuration as possible, too.

/cc: @spalger (JFYI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

5 participants