Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Choose legend position for both XY and pie charts separately #68293

Closed
wylieconlon opened this issue Jun 4, 2020 · 1 comment · Fixed by #70619
Closed

[Lens] Choose legend position for both XY and pie charts separately #68293

wylieconlon opened this issue Jun 4, 2020 · 1 comment · Fixed by #70619
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

Legend options are part of the chart-level options because there is only one legend shown. Legends should not be part of the Lens editor, because not every visualization has a legend- this decision is described below.

The most commonly used legend positions are Right and Bottom- having a bottom legend lets it have more space:

Screenshot 2020-06-04 13 17 41

Decision: Legend settings are not shared across chart types

Because each chart type implements its state separately, I am not sure that we will be able to keep the legend position consistent when switching from XY -> Pie. For example, if the user chooses a Bottom legend for the XY chart, and then switches to Pie, I would expect that the legend becomes the default of Right.

Part of the styling meta issue

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants