-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace option for navigateToApp #68527
Comments
Pinging @elastic/kibana-platform (Team:Platform) |
By legacy route, you means route to a legacy plugin? Because when navigating from and/or to a legacy app, we are not using the history and just performing a plain kibana/src/core/public/application/application_service.tsx Lines 115 to 117 in a091124
So we would need to handle both cases when implementing |
That was badly worded by me - legacy route doesn't mean legacy plugin necessarily. Just in general when a route has moved and requests to the old one should be redirected to the new one. For my use case it's not necessary to support legacy routing. |
Blocker for #68284 that needs to lands in |
Currently
core.application.navigateToApp
is always writing a new history entry for doing a navigation (kibana/src/core/public/application/application_service.tsx
Line 131 in a091124
In some cases when no history entry should be written, a
replace
option should be available.One use case for this is redirecting legacy routes - in that case producing a history entry will cause the browser back button to break because it will just lead to the redirected route again.
cc @restrry
The text was updated successfully, but these errors were encountered: