Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve FTR config type safety #69393

Open
mshustov opened this issue Jun 17, 2020 · 1 comment
Open

Improve FTR config type safety #69393

mshustov opened this issue Jun 17, 2020 · 1 comment
Labels
enhancement New value added to drive a business result Feature:Functional Testing impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Operations Team label for Operations Team

Comments

@mshustov
Copy link
Contributor

Migrate FTR to @kbn/config-schema to support type-safe config and get rid of direct Joi usage.
After that we could improve type-safety of FTR config:

type FtrConfigFactory = (context: FtrConfigProviderContext) => FtrConfig;
const config: FtrConfigFactory = async function ({ readConfigFile }) {..}
export { config as default };
@mshustov mshustov added Team:Operations Team label for Operations Team enhancement New value added to drive a business result Feature:Functional Testing labels Jun 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mshustov mshustov mentioned this issue Jun 17, 2020
Merged
2 tasks
@mshustov mshustov mentioned this issue Jul 3, 2020
Open
41 tasks
This was referenced Apr 26, 2021
Open
Merged
@tylersmalley tylersmalley added 1 and removed 1 labels Oct 11, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Oct 12, 2021
@tylersmalley tylersmalley removed loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. EnableJiraSync labels Mar 16, 2022
@exalate-issue-sync exalate-issue-sync bot added the impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Functional Testing impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:Operations Team label for Operations Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tylersmalley @mshustov @elasticmachine