-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why do widths change when hiding a value? #72319
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
@markov00 It seems like this is unconfigurable |
Pinging @elastic/datavis (Feature:ElasticCharts) |
Hi @kmartastic what would be from your point of view the preferred behavior? when hiding series these are the involved properties that can change/be changed from a visualization point of view:
This is what happens in elastic-charts by default when hiding a series, and it was a replica of the current preexisting behavior of TSVB. We can for sure add a way to configure this behavior that, from IMHO, can be different depending on the use case:
All seems valid options to me, so probably @elastic/chats should provide options for all these cases. On your gif is also difficult to understand exactly what is going on without a proper x-axis as a baseline, the data is also incomplete (or at least is incomplete in this screenshot) so I don't have a good perception of what is going on there, could you please post a gif that covers the whole chart? |
Thanks for the thoughtful responses. I'll get back with my thoughts and the full chart gif. @markov00 |
Hey @markov00 -- just getting back to this. I've been playing with Lens. I.e, exploring data, looking for something interesting, but without a specific question in mind. With only a few values (bars). I don't get why bars are not centered on their ticks. The misalignment with the axis labels feels off. There is already so much spacing between bars, that the relatively small increase in width feels more disruptive than it improves readability. I say this as I am interacting with the data; if I immediately brought this chart on to a dashboard, I might want readability maximized. With a large number of values. The resizing, positioning changes are barely noticeable going from 30 to 10 values. What I think would be helpful is an animated transition when removing/adding elements of the chart. Right now, clicking on a value to hide it from the chart, does several things at once -- removes bars, resizes widths of remaining bars, and potentially repositions bars (if the value removed was in the middle of other values). An animated transition would help maintain reference with the data; would feel less jarring, and in my opinion might be a better experience than adding more config/options for how charts should behave when hiding/filtering, etc. Happy to jump on a zoom or provide more detail. |
@kmartastic The axis alignment is off because of this issue elastic/elastic-charts#350 but for now that is expected behavior. In the future we plan to have compacting logic to clean up this behavior. To your point on animated transitions, I agree that would be helpful. We removed the feature a while ago due to some complications (elastic/elastic-charts#164) but have not yet prioritized re-enabling the feature. |
Is the issue in elastic-charts a clear an unambiguous fix for this, or is there more discussion needed? I'd like to change the title of this issue if we've already decided on the solution. |
@wylieconlon Not sure, @monfera is working on this actively for the small multiples functionality (elastic/elastic-charts#500). Maybe he or @markov00 might have better insights. |
I've missed the followup here sorry, yes the elastic/elastic-charts#350 issue has everything we need to fix it. |
Why do widths change when hiding a value?
It makes keeping a visual reference difficult.
The text was updated successfully, but these errors were encountered: