Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a convention for CSS class names generated within js files #74390

Open
mshustov opened this issue Aug 5, 2020 · 0 comments
Open

Add a convention for CSS class names generated within js files #74390

mshustov opened this issue Aug 5, 2020 · 0 comments
Labels
discuss enhancement New value added to drive a business result

Comments

@mshustov
Copy link
Contributor

mshustov commented Aug 5, 2020

In #74091 I had to mute @typescript-eslint/naming-convention rule manually for CSS classes created in react components because they don't abide by the regular JS naming convention. Examples:

  • componentName__element--modifier
  • componentName__element__element

// eslint-disable-next-line @typescript-eslint/naming-convention
'mgtAdvancedSettingsForm__bottomBar--pushForNav':

We need to find a solution to exclude such variables from the linting on the project level. For example, we could use a special prefix or a suffix to filter them out.

@mshustov mshustov added discuss enhancement New value added to drive a business result labels Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss enhancement New value added to drive a business result
Projects
None yet
Development

No branches or pull requests

1 participant