Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Enable fitting functions for stacked area charts #75031

Closed
flash1293 opened this issue Aug 14, 2020 · 3 comments · Fixed by #75700
Closed

[Lens] Enable fitting functions for stacked area charts #75031

flash1293 opened this issue Aug 14, 2020 · 3 comments · Fixed by #75700
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

In the latest version of elastic-charts, stacked charts support fitting functions as well https://github.com/elastic/elastic-charts/blob/master/CHANGELOG.md#features

Currently, fitting functions are disabled for stacked area charts.

By enabling it, we can use the same fitting functions for them as well.

@flash1293 flash1293 added good first issue low hanging fruit enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor Author

@nickofthyme You linked the eui update to this issue - is it actually fixed by the new elastic-charts version alone? Looks like this also needs a small change within Lens (enabling the option in the menu)

@nickofthyme
Copy link
Contributor

nickofthyme commented Aug 31, 2020

@flash1293 Yeah there was a dependency on eui for some unrelated chart changes but specifically @elastic/charts@21.0.0 was what enabled stacked fit functions.

I added the stacked_area type to the fit function enablement logic, not sure if there is anything else to do than that. But with the change in #75700 I was able to use fit functions on stacked areas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens good first issue low hanging fruit Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants