Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocumentMigrator exception not handled by logger #75055

Closed
tylersmalley opened this issue Aug 14, 2020 · 1 comment · Fixed by #77018
Closed

DocumentMigrator exception not handled by logger #75055

tylersmalley opened this issue Aug 14, 2020 · 1 comment · Fixed by #77018
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@tylersmalley
Copy link
Contributor

tylersmalley commented Aug 14, 2020

When debugging a 7.9.0 issue with @joshdover, we discovered that the migration error was not present in the logs as would be expected. This makes understanding failed migrations on Cloud difficult if not impossible.

Example failure:

Error: Document "5a03eb37-2240-4bdd-a999-91e1d427f5bf" has property "alert" which belongs to a more recent version of Kibana [7.9.0]. The last known version is [undefined] [object Object]
    at find (/home/tyler/elastic/kibana/src/core/server/saved_objects/migrations/core/document_migrator.ts:351:13)
    at Array.find (<anonymous>)
    at nextUnmigratedProp (/home/tyler/elastic/kibana/src/core/server/saved_objects/migrations/core/document_migrator.ts:337:21)
    at applyMigrations (/home/tyler/elastic/kibana/src/core/server/saved_objects/migrations/core/document_migrator.ts:262:18)
    at DocumentMigrator.transformDoc (/home/tyler/elastic/kibana/src/core/server/saved_objects/migrations/core/document_migrator.ts:244:9)
    at transform (/home/tyler/elastic/kibana/src/core/server/saved_objects/migrations/core/document_migrator.ts:155:17)
    at Immediate.setImmediate (/home/tyler/elastic/kibana/src/core/server/saved_objects/migrations/core/migrate_raw_docs.ts:84:17)
    at runCallback (timers.js:705:18)
    at tryOnImmediate (timers.js:676:5)
    at processImmediate (timers.js:658:5)

(don't read into this particular error, it was caused by a migration added in 7.9.0 and removed before its release)

@tylersmalley tylersmalley added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects labels Aug 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
3 participants