Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from hash based routing #76348

Closed
pgayvallet opened this issue Sep 1, 2020 · 1 comment · Fixed by #76421
Closed

Migrate from hash based routing #76348

pgayvallet opened this issue Sep 1, 2020 · 1 comment · Fixed by #76421
Assignees
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@pgayvallet
Copy link
Contributor

The uptime app is currently using hashbang routing by having a BrowserRouter with an appRoute containing a hashbang suffix.

Hashbang routing is not supported by the Kibana Platform. The application's routing need to be migrated to leverage the ScopedHistory exposed to the plugins instead.

Related files:

core.application.register({
appRoute: '/app/uptime#/',
id: PLUGIN.ID,

import { BrowserRouter as Router } from 'react-router-dom';

<Router basename={routerBasename}>

@pgayvallet pgayvallet added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Sep 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants