Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change plugin id for beats_management to beatsManagement #76405

Closed
tylersmalley opened this issue Sep 1, 2020 · 3 comments
Closed

Change plugin id for beats_management to beatsManagement #76405

tylersmalley opened this issue Sep 1, 2020 · 3 comments

Comments

@tylersmalley
Copy link
Contributor

Similar to #59191

The Platform now logs a warning when plugin IDs are not in camelCase format. beats_management needs to be renamed to beatsManagement in order to make this warning go away. This is important because this warning is confusing to users. We could just log the message in development, but it seems just as easy to just go ahead and do the rename now.

All this should entail is changing the id field in the kibana.json file and updating any plugins that depend on this plugin to use the new id when calling this plugin's APIs.

The config path does not need to change and should remain in snake_case.

@elasticmachine
Copy link
Contributor

Pinging @elastic/integrations (Team:Beats)

@pgayvallet
Copy link
Contributor

I think that's already fixed in current master?

"id": "beatsManagement",

@afharo
Copy link
Member

afharo commented Feb 11, 2021

Closing as this seems to be already fixed. Feel free to reopen if needed.

@afharo afharo closed this as completed Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants