-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUM Dashboard] Hovering on RUM core web vitals percentages showing white background in dark mode #77283
Comments
Pinging @elastic/datavis (Feature:ElasticCharts) |
Pinging @elastic/kibana-design (Team:Kibana-Design) |
This actually is a custom data visualization not provided by the Charts team. Tagging in the @elastic/observability-design team. |
Pinging @elastic/uptime (Team:uptime) |
@cchaos This is actually a chart issue. |
@cchaos This is coming from changes made to the legend with new legend actions here. I just used the background color used in the mock ups from @miukimiu but couldn't find the color in the eui pallet. Do you know of a suitable color to use from your scss variables for |
Ah, I didn't realize this sort of chart exists in Charts, or is it just a simple 1 bar horizontal chart? Anyway, yes this is why using hex values directly is problematic and any colors should always be a EUI SASS var or computation of. EUI has a focus background color that we use for buttons like this called |
This is a custom component, it's not using chart legends or bar. I will fix this. |
@shahzad31 Oh looks like you are correct, however this raised a similar issue in the charts legend. |
Kibana version: 7.10.0-SNAPSHOT
Elasticsearch version: 7.10.0-SNAPSHOT
Original install method (e.g. download page, yum, from source, etc.): Docker
Describe the bug:
White background color is displayed if hovering on core web vitals percentages in dark mode.
Also applies to the pie chart legends.
Steps to reproduce:
Screenshots (if relevant):
Expand
@shahzad31 for your review.
The text was updated successfully, but these errors were encountered: