-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Improve range formatting #77881
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
Pinging @elastic/kibana-app-arch (Team:AppArch) |
There's also another proposal of using the |
I like the idea of representing the range by showing the approximate maximum value, but I don't think the symbol
|
There are some edge cases where this breaks down. I'm not saying they are blocking this proposal but we should be aware of them. E.g. if a field has a byte formatter configured, we would want to use that formatter for the individual values. So in the case of @wylieconlon s example from above it would say The same would happen in other cases as well (e.g. the duration formatter)
Another example: A field configured to not show digits after the decimal point. In this case, Kibana formats like this:
If a range is configured on this field, the user can use a range like 4 (inclusive) to 6(exclusive). How should we show this range on a chart? I see three options:
|
@dej611 Thanks for listing out that proposal ( |
I see what you mean. Perhaps having different formats rather than a single universal one could be a potential option - in particular for those open ranges. |
Here's a small PoC to add alternative range formatters: master...dej611:feature/range-alternative-formatter (it is using the |
Talked offline with @AlonaNadler and we agreed the edge cases mentioned above are not a problem to implement the proposal as long as we also provide a way to set custom labels. If a user runs into an edge case where they feel the labels on the chart are misleading, they can easily change it, but for the 99% use case it's a net improvement. |
Currently the range field formatter uses
≥
and<
. This is not optimal as it's hard to understand for some users and we can't show an exemplary tooltip in all places.Copying over @cchaos writeup how it could work (with Lens as an example):
I still find the format
≥ 0 and < 1000
extremely hard to read. I understand that the distinction is necessary when creating to interval, but I think we can do better for giving understanding to the viewer of the chart.How I see it is that
≥ 0 and < 1000
is roughly0 - 999
but not necessarily because it could be0 - 999.99999
as well. So here what I'm seeing is that the end value depends on the decimal place. What this means is that we still need to use the "Value format" options we have for Top values in Ranges as well.Then using that format, we can properly display the actual value range instead of the hard to understand mathematical range.
Here are 2 screens that emulate what I mean and a Prototype
The text was updated successfully, but these errors were encountered: