Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs + Metrics UI] Migrate to TS project references #80995

Closed
15 tasks done
weltenwort opened this issue Oct 19, 2020 · 6 comments · Fixed by #90118
Closed
15 tasks done

[Logs + Metrics UI] Migrate to TS project references #80995

weltenwort opened this issue Oct 19, 2020 · 6 comments · Fixed by #90118
Assignees
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@weltenwort
Copy link
Member

weltenwort commented Oct 19, 2020

Summary

Now that the Kibana build system supports using TypeScript project references (#46773), the infra plugin must be migrated to participate. This is part of the overall effort tracked at #80508.

Blockers

This is currently blocked by the migration status of some of the plugin dependencies:

  • features
  • usageCollection
  • spaces
  • data
  • dataEnhanced
  • visTypeTimeseries
  • alerts
  • triggersActionsUi
  • ml
  • observability
  • licenseManagement
  • kibanaUtils
  • kibanaReact
  • apm
  • home

Acceptance criteria

The infra plugin can be referred to using a project refrence, which means it...

  • has a tsconfig.json file which conforms to the documented form
  • references the dependencies
  • emits type definitions for its public API
  • compiles in tsc's build mode

Related information

@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Oct 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort
Copy link
Member Author

ℹ️ The ml (#90021) and observability (#89320) plugins are the only remaining unmigrated dependencies. They are about to be migrated which should unblock this issue.

@jfsiii
Copy link
Contributor

jfsiii commented Feb 3, 2021

The majority of the work can be done without waiting for other plugins to complete. Fleet used the approach suggested in #80508 (comment) for #87574 and it worked quite well

@smith
Copy link
Contributor

smith commented Feb 3, 2021

#90049 on APM takes a similar approach. If nobody has a draft up I can try to take a crack at it tomorrow.

@smith
Copy link
Contributor

smith commented Feb 3, 2021

#90118 is open as a draft. Will update once #87574 is merged.

@jfsiii
Copy link
Contributor

jfsiii commented Feb 8, 2021

#90118 is open as a draft. Will update once #87574 is merged.

That's great news! infra was the last thing #87574 was waiting for

// TODO { "path": "../infra/tsconfig.json" },

I'm watching #90118 and will merge #87574 as soon as that lands. Thanks, again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants