Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) Remove mention of deprecated EuiKeyboardAccessible #81062

Closed
myasonik opened this issue Oct 19, 2020 · 1 comment
Closed

(Accessibility) Remove mention of deprecated EuiKeyboardAccessible #81062

myasonik opened this issue Oct 19, 2020 · 1 comment
Assignees
@alexwizp
Labels
loe:needs-research This issue requires some research before it can be worked on or estimated Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@myasonik
Copy link
Contributor

EuiKeyboardAccessible was deprecated because it was abused more often than it was used successfully so we need to remove it from Kibana before December 2020.

It doesn't seem like it's actually used but it is mentioned here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/security_solution/public/resolver/view/process_event_dot.tsx#L273-L276

If the comment is just outdated, please remove it to avoid confusion. But there is concern that something in such a brittle DOM/ARIA structure may not be working currently if EuiKeyboardAccessible was assumed to be there somewhere and isn't.
@myasonik myasonik added Project:Accessibility loe:needs-research This issue requires some research before it can be worked on or estimated Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Oct 19, 2020
@alexwizp alexwizp self-assigned this Oct 9, 2024
@alexwizp
Copy link
Contributor

alexwizp commented Oct 9, 2024

EuiKeyboardAccessible has been removed in #69098. No more imports from Kibana. Looks like this issue is obsolete and can be closed.

@alexwizp alexwizp closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
loe:needs-research This issue requires some research before it can be worked on or estimated Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@myasonik @alexwizp