-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Canvas] Use "Add New" Embeddable flow like Dashboard #81812
Comments
Pinging @elastic/kibana-canvas (Team:Canvas) |
Proposed updates to the flyout are related to the toolbar work. Explained here: #82906 |
We want to use the same panel toolbar from Dashboard (see #85663) in Canvas to handle creating new by-value/by-reference embeddable and adding existing by-reference embeddables. In order to integrate the panel toolbar, Canvas would need to generically support both by-value and by-ref for any type of embeddable. This is potentially a breaking change and requires some research. This panel toolbar expects an Embeddable Container to be passed into the component to handle adding embeddables, so it'll require turning the Canvas workpad in an embeddable container. Q: Do we need to turn workpads into an Embeddable Container? Would this support native elements? Would this require turning Canvas elements into embeddables? To persist by-value embeddables, we also need to store the embeddable input object as part of the workpad object and will result in changes to the Workpad schema. |
@cqliu1 In the immediate term, I'm more interested in having a consistent UI than I am a consistent embeddables architecture. In other words, while we can do research on the by-value/by-reference change, the components that make up the toolbar need not make that distinction... they just need to look the same. We could propose a pattern:
We could implement this pattern in Canvas today using the same components... just not those with particular business logic. |
Just some notes from our meeting of generally what we think needs to happen to get this done. I will break this up into smaller issues that we can knock out one by one.
|
Canvas currently uses an Add Embeddable flow that only allows you to add Saved Objects backed Embeddables.
The flyout used by dashboard includes an "Add New" button that lets you build embeddable certain kinds of embeddables (ML Swimlane) on the fly. Canvas should switch to using this method so that Canvas can take advantage of these new kinds of embeddables that do not require a saved object.
The text was updated successfully, but these errors were encountered: