-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ES UI form lib from es_ui_shared plugin into a package #82489
Comments
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
@elastic/kibana-operations do you know how far away we are from effectively no longer requiring that static-code that wants to be shared reside in the |
@kobelb can you give me some more details about what you mean by "static-code that wants to be shared"? I think the code sharing we've enabled between plugins qualifies, but I could interpret that a number of ways and I don't think that packages improve our ability to share code other than the fact that prevents us from needing to use relative import paths. Is that what you mean? |
@spalger apologies for the vague phrasing. It's my understanding that as part of the move to Bazel, that we'll be removing the differences between Long-term, we plan to change the code organization entirely and use a domain-based approach per #71566, which would get rid of the |
Hmm, sounds like a question for @mistic and @tylersmalley then, I don't think that Bazel will be removing all of the differences between packages and plugins, and but I'm not super up-to-date with those plans and maybe we'll be accessing plugins as top-level node modules in the future like we do with packages today... |
Pinging @elastic/kibana-management (Team:Kibana Management) |
After discussing this, ES UI has decided this move is worth the following benefits:
brace/mode/json
which adds 48kb to the page load bundle size ([ES UI] Reintroduce import of brace/mode/json #78571 (comment)). Moving the lib to a package will reduce the page load bundle size by more than this amount.Prepare for broader adoption. Currently, we want to limit the consumption of this library due to lack of capacity for maintenance and support. We can enforce this limit in the README and docs. Once we grow our capacity for supporting more consumers, a package will be easier to discover and consume than a plugin.After discussion with Stacey, we agreed that the long-term plan for the form lib isn't clear enough to consider this as more than a speculative benefit.CC @kobelb @stacey-gammon
The text was updated successfully, but these errors were encountered: