Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KUI traces from Visualizations code #82711

Closed
timroes opened this issue Nov 5, 2020 · 2 comments · Fixed by #82810
Closed

Remove KUI traces from Visualizations code #82711

timroes opened this issue Nov 5, 2020 · 2 comments · Fixed by #82810
Assignees
@stratoula
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@timroes
Copy link
Contributor

timroes commented Nov 5, 2020

We should remove all usage left-overs of KUI (Kibana UI Framework) from the visualizations code, since we want to remove it (see #46410).

It seems we only have usage of the classes and icons left over in https://github.com/elastic/kibana/blob/master/src/plugins/visualizations/public/embeddable/disabled_lab_visualization.tsx

We should make sure to use EUI properly in this file, replace the font awesome icon by an EUI icon, and just get rid of the custom KUI classes altogether in this file.
@timroes timroes added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added the technical debt Improvement of the software architecture and operational architecture label Nov 5, 2020
@lizozom
Copy link
Contributor

lizozom commented Nov 5, 2020

Update status on main meta issue

@stratoula stratoula self-assigned this Nov 6, 2020
@stratoula stratoula mentioned this issue Nov 6, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stratoula stratoula

Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Visualizations] Remove kui usage stratoula/kibana
4 participants
@timroes @lizozom @elasticmachine @stratoula