Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] An error page is displayed when you manually erase out the fields on the X/Y axis which could be improvized. #83466

Closed
rashmivkulkarni opened this issue Nov 16, 2020 · 8 comments
Labels
blocked bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@rashmivkulkarni
Copy link
Contributor

Kibana version: found in 7.10

Elasticsearch version: 7.10

On Lens visualization, when you clear the the Y axis fields manually ( not reset the layer) , it shows an error stating

An error occurred when loading data.

Show details of error
[lens_merge_tables] > [esaggs] > Cannot read property 'forEach' of undefined

Screen Shot 2020-11-16 at 10 48 07 AM

This could be improvised - either show a more user-friendly error or bring the user back to start where you drag and drop the fields.
Screen Shot 2020-11-16 at 10 47 33 AM

@rashmivkulkarni rashmivkulkarni added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon changed the title An error page is displayed when you manually erase out the fields on the X/Y axis which could be improvized. [Lens] An error page is displayed when you manually erase out the fields on the X/Y axis which could be improvized. Nov 16, 2020
@dej611
Copy link
Contributor

dej611 commented Nov 17, 2020

This has been fixed since 7.11: #81439

@flash1293
Copy link
Contributor

The behavior for this specific case got slightly better in 7.11 but it's not fixed. Right now this happens:

  • "No results" is shown
  • Dimension doesn't have a label
  • Config flyout can't be opened anymore once it's closed (still possible to recover by deleting the dimension and starting over)

Screenshot 2020-11-17 at 09 48 48

I suggest we don't even allow clearing out the field, I can't think of a good reason a user would want to do this.

@dej611
Copy link
Contributor

dej611 commented Nov 17, 2020

Oh I didn't notice the field was white. It could be probably be handled by the same validation logic in 7.11

@flash1293
Copy link
Contributor

@dej611 I guess it would be possible, but I don't really see a good reason (see the last sentence below the screenshot in my previous comment):

I suggest we don't even allow clearing out the field, I can't think of a good reason a user would want to do this.

@wylieconlon
Copy link
Contributor

I've opened a related EUI bug for this, because it seems like part of the issue is that you are allowed to press the delete key: elastic/eui#4394

@dej611
Copy link
Contributor

dej611 commented Apr 27, 2021

Partially mitigated by #98295

@flash1293
Copy link
Contributor

This isn't possible anymore in current version of Lens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants