Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Show validation errors on dashboards #86278

Closed
flash1293 opened this issue Dec 17, 2020 · 5 comments · Fixed by #90668
Closed

[Lens] Show validation errors on dashboards #86278

flash1293 opened this issue Dec 17, 2020 · 5 comments · Fixed by #90668
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

In the Lens editor we are rendering a nice error message if there are inconsistencies in the state (e.g. if a field is not available)

In the embeddable, this logic is not used and it is attempted to run the expression. This results in slightly weird error messages:
Screenshot 2020-12-16 at 15 45 12

In some cases (specifically on changing or disappearing fields) we could do better here and show the validation error message instead.

@flash1293 flash1293 added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Dec 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes
Copy link
Contributor

timroes commented Dec 17, 2020

This would most likely also be helping when changing a runtime field type that now creates an inconsistent state.

@flash1293
Copy link
Contributor Author

flash1293 commented Dec 18, 2020

@timroes yes, it would help with that situation as well - I checked the logic and it already catches type mismatches.

@wylieconlon
Copy link
Contributor

This issue might be more important to fix now that we have more invalid states to support calculations.

@flash1293
Copy link
Contributor Author

I agree @wylieconlon - it should also be a simple change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants