Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Service overview: Change the instance links for any language other than Java to filter the Metrics page by service.node.name #89528

Closed
formgeist opened this issue Jan 28, 2021 · 7 comments · Fixed by #91796
Assignees
Labels
apm:service-overview enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support

Comments

@formgeist
Copy link
Contributor

Summary

Since all agents other than Java only have the default Metrics page without instance detail pages, I would suggest a small enhancement to the links from the Instances table. Linking to the Metrics page, but use the selected service.node.name would filter the Metrics page by that instance.

Screenshot 2021-01-28 at 09 04 13

Screenshot 2021-01-28 at 09 04 46

@formgeist formgeist added Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result labels Jan 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

sorenlouv commented Jan 28, 2021

I think this is a good enhancement in the short term. Ideally, I'd think all languages should behave the same, meaning that we'd get an instance overview page and instance details page everywhere and not just for java.

@formgeist
Copy link
Contributor Author

@sqren Yeah, there's an updated instances view in the works but it's a larger overhaul, so it'll be some time before we're there.

@dgieselaar
Copy link
Member

I actually implemented this but looks like it broke in #86986 when MetricOverviewLink started using EuiLink instead of APMLink. See

@sorenlouv
Copy link
Member

sorenlouv commented Jan 28, 2021

but it's a larger overhaul

Perhaps exactly for this reason we should clean it up now. Right now we have duplicated the logic for java vs the other languages. I suggest that we remove one of the implementations - preferably the non-java implementation.

@sorenlouv
Copy link
Member

sorenlouv commented Jan 28, 2021

Currently the overview page for java looks like this:

image

We can make the columns conditional so for the other languages they just show CPU and Memory (for now at least - I'm sure down the line we want to add more metrics for them as well).
image

@formgeist
Copy link
Contributor Author

Discussed this at refinement yesterday, we've decided to only fix the linking from non-JVM instances to filter the Metrics view by the selected instance ID instead of implementing a larger overhaul of the Metrics view for non-Java language agents in lieu of the Service instance design that is going on at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:service-overview enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants