-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Service overview: Change the instance links for any language other than Java to filter the Metrics page by service.node.name
#89528
Comments
Pinging @elastic/apm-ui (Team:apm) |
I think this is a good enhancement in the short term. Ideally, I'd think all languages should behave the same, meaning that we'd get an instance overview page and instance details page everywhere and not just for java. |
@sqren Yeah, there's an updated instances view in the works but it's a larger overhaul, so it'll be some time before we're there. |
Perhaps exactly for this reason we should clean it up now. Right now we have duplicated the logic for java vs the other languages. I suggest that we remove one of the implementations - preferably the non-java implementation. |
Discussed this at refinement yesterday, we've decided to only fix the linking from non-JVM instances to filter the Metrics view by the selected instance ID instead of implementing a larger overhaul of the Metrics view for non-Java language agents in lieu of the Service instance design that is going on at the moment. |
Summary
Since all agents other than Java only have the default Metrics page without instance detail pages, I would suggest a small enhancement to the links from the Instances table. Linking to the Metrics page, but use the selected
service.node.name
would filter the Metrics page by that instance.The text was updated successfully, but these errors were encountered: