-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Support icicle chart #89860
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
There are some rendering caveats that I think we need to be aware of when testing this:
|
Yeah, the screenshot is a little misleading. The way I had expected it to work in case of Lens (as another partition chart type):
|
@flash1293 great, I think we have the same expectations. So even though it's usually called an "icicle chart" I think we are agreeing that we won't see the "spike" effect that is shown in the original screenshot. Instead, we are expecting the chart to look like a rectangle. |
We should propably not call it icicle chart in the UI because it will be really low on icicles |
So for reference, I think our charts will look a lot more like this public example by Adam McCann: The important parts to identify about how this looks:
However we would not be able to support the Axis labeling like that example shows. |
@wylieconlon we've been working on separating the axis and making it its own thing. That, plus its reuse should make it possible to add a temporal or quantitative axis to monotonic (mostly linear / continuous) projections eg. icicle/flame. Charts that have two such projections, at the present time mosaic/marimekko, could gain up to two optional axes. Custom sort orders are already in for pie/sunburst, and icicle/flame have just always followed the order the data is specified in, because that was deemed the common use case at the time. For variety's sake, there's yet another sorting non-uniformity: treemaps can't be meaningfully sorted, as the layout algo determines the placement (I'm sure there's some special case for treemaps when sorting would be meaningful. Regarding color, currently it's up to Lens to provide the colors. I don't necessarily think that the same exact strategy must be used for icicle/flame as for sunburst; it varies by
Still, a sunburst-type coloring probably works too as an initial option, after all it's yet another type of categorical coloring. One thing to consider with icicle/flame is the currently click activated in-chart drilldown, which also needs |
Closing this issue until we have customer's requesting this chart type given the other partition charts already supported in Lens. |
elastic-charts supports icicle charts: https://elastic.github.io/elastic-charts/?path=/story/flame-alpha--icicle-chart
We should support this chart type as an alternative to other partition charts (pie/donut/tree map). Be aware to not confuse this feature with flame charts using a time-based x axis (something we can't easily support today)
The text was updated successfully, but these errors were encountered: